Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(konnect): add generic objectListToReconcileRequests #680

Merged
merged 1 commit into from
Oct 2, 2024
Merged

refactor(konnect): add generic objectListToReconcileRequests #680

merged 1 commit into from
Oct 2, 2024

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Oct 2, 2024

What this PR does / why we need it:

This PR adds objectListToReconcileRequests which generically converts list of objects into []ctrl.Request.

@pmalek pmalek added this to the KGO v1.4.x milestone Oct 2, 2024
@pmalek pmalek self-assigned this Oct 2, 2024
@pmalek pmalek marked this pull request as ready for review October 2, 2024 10:09
@pmalek pmalek requested a review from a team as a code owner October 2, 2024 10:09
@pmalek pmalek requested a review from czeslavo October 2, 2024 10:49
czeslavo
czeslavo approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@czeslavo czeslavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👍

@pmalek pmalek merged commit 820f2c8 into main Oct 2, 2024
21 checks passed
@pmalek pmalek deleted the konnect-refactor-objectlist-to-reconcile branch October 2, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czeslavo czeslavo czeslavo approved these changes

Assignees

@pmalek pmalek

Labels
None yet
Projects
None yet
Milestone
KGO v1.4.x
Development

Successfully merging this pull request may close these issues.
2 participants
@pmalek @czeslavo